Skip to content

firefox: fixup build on aarch64-linux#210859

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
vcunat:p/firefox-gcc_s
Jan 15, 2023
Merged

firefox: fixup build on aarch64-linux#210859
mweinelt merged 1 commit intoNixOS:masterfrom
vcunat:p/firefox-gcc_s

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Jan 15, 2023 •
edited
Loading

It's the issue with old libgcc_s propagated via our glibc package; e.g. #209113

Description of changes
Things done
  • Built on platform(s); no rebuild on most
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vcunat
firefox: fixup build on aarch64-linux
cdf0283 
It's the issue with old libgcc_s propagated via our glibc package; e.g.
NixOS#209113
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Jan 15, 2023
@vcunat
Copy link
Member Author

vcunat commented Jan 15, 2023

Example on Hydra: https://hydra.nixos.org/build/205354157

Testing build's been in progress for almost an hour on aarch64.nixos.community machine, so I expect this will work and I'll undraft afterwards.

@vcunat vcunat marked this pull request as ready for review January 15, 2023 09:29
@vcunat vcunat requested a review from mweinelt as a code owner January 15, 2023 09:29
@ofborg ofborg bot requested review from edolstra, lovesegfault, nbp and squalus January 15, 2023 09:32
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 15, 2023
@mweinelt mweinelt merged commit 0d00dd3 into NixOS:master Jan 15, 2023
@K900 K900 mentioned this pull request Jan 15, 2023
Closed
@vcunat vcunat deleted the p/firefox-gcc_s branch January 15, 2023 09:48
wegank added a commit to wegank/nixpkgs that referenced this pull request Mar 2, 2023
@wegank
firefox, spidermonkey: remove NIX_LDFLAGS
11b07d9 
This commit reverts NixOS#210859, since aarch64-linux now uses GCC 12 by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@edolstra edolstra Awaiting requested review from edolstra

@squalus squalus Awaiting requested review from squalus

@nbp nbp Awaiting requested review from nbp

Assignees

No one assigned

Labels

1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vcunat @mweinelt